Go: Update use of context in all Go examples #6945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laren-AWS
added
the
Task
Laren-AWS
requested review from
a team,
DavidSouther and
meyertst-aws
and removed request for
a team and
DavidSouther
meyertst-aws
approved these changes
Oct 1, 2024
rlhagerm
added
On Call Review complete
More context updates. More context updates, plus a few fixups to Redshift and S3. Add missed context in iam tests.
rlhagerm
force-pushed
the
go-context-update
branch
from
736778d to
093241b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Go examples all created a new
context.TODO()on the fly whenever a context was needed. This is not best practice for context handling. This PR updates all Go examples to create a rootcontext.Background()object inside themainfunction and pass it down to all of the leaf functions.Two additional changes are included as well to ensure tests pass:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.